Repository navigation
Use namespaced middleware ops; tidy two request params - #600
Merged
Merged
Conversation
Three improvements found while auditing the middleware request/response shapes: - Use refactor-nrepl's namespaced op names (refactor/find-symbol, etc.) instead of the bare ones. refactor-nrepl registers every op under both forms, treats the namespaced one as canonical, and plans to drop the bare names; namespacing also avoids op-name collisions with other middleware. Prefixing is centralized in cljr--create-msg and cljr--op-supported-p (plus the one inline extract-definition request). Requires refactor-nrepl 3.13.0+; the injected version is now 3.14.0. - Send an explicit "false" for ignore-errors when cljr-ignore-analyzer-errors is nil, instead of a nil value that nREPL drops (leaving the middleware on its lenient default). The strict behavior the option documents now actually takes effect. - Drop the obsolete language-context param from the suggest-libspecs request; refactor-nrepl has read buffer-language-context / input-language-context since 3.7.0. Validated live against refactor-nrepl 3.14.0: op-support, version, rename, clean-ns and suggest-libspecs all work under the namespaced ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three improvements from auditing the middleware request/response shapes:
refactor/find-symbol,refactor/clean-ns, etc. instead of the bare names. refactor-nrepl registers every op under both forms, treats the namespaced one as canonical, and plans to drop the bare names; namespacing also avoids op-name collisions with other middleware. Prefixing is centralized incljr--create-msgandcljr--op-supported-p. Requires refactor-nrepl 3.13.0+ (injected version bumped to 3.14.0; README updated).cljr-ignore-analyzer-errorsis nil (default), the request sent a nil value that nREPL drops on the wire, leaving the middleware on its lenient default. It now sends an explicitfalse, so the strict behavior the option documents actually takes effect. Note: a project with an unanalyzable namespace will now surface a warning by default instead of silently skipping it.language-contextparam from the suggest-libspecs request (superseded bybuffer-language-context/input-language-contextin refactor-nrepl 3.7.0).Validated live against refactor-nrepl 3.14.0: op-support, version, rename, clean-ns and suggest-libspecs all work under the namespaced ops. Reviewed for prefix completeness (every op path routes through the two centralized funnels — no bare/namespaced drift, no double-prefix).